Conversation
|
Thanks for the PR. |
|
hi @zeograd , yep, the test suite is passing... |
|
Thanks for your answer. The test suite is failing hard on my side (on python 2.7.12 under debian unstable x64) even on the most basic equality test (the rest is probably failing due to this). I never coded in cython, but since there is a custom eq method on the PyLine class, I'd expect a similar method on the GLine implementation, which seems missing. Have I missed something about this part ? |
|
@zeograd , possible the python rather than cython module was loaded when the PR was submitted. |
|
@jf--- the test before PR being against the python version is probable Regarding having both implementations, I made local changes to make cython optional at build time (it's nice to have but I prefer to keep the hard requirements as low as possible). So, for testing, it might be easier to have 2 virtualenvs, one with and another without cython support. In your environment, do you confirm that tests fail when the cython version is in use ? |
No description provided.